Re: [PATCH] gitk - restore operation of git-reset on Cygwin

From: Mark Levedahl <mlevedahl@gmail.com>
Date: May 23, 2008, 22:26 UTC
Message-ID: <483744AB.8070509@gmail.com>
In-Reply-To: <18486.15879.551874.408651@cargo.ozlabs.ibm.com>

Paul Mackerras wrote:

Show 18 quoted lines

> Mark Levedahl writes:
>
>   
>> Commit 6df7403a98737 modified the call to git-reset to invoke git
>> directly rather than using "sh -c", but is redirecting stderr to stdout.
>> This does not work on Cygwin, probably because the Tcl/Tk package is
>> a windows program rather than Cygwin. The result is always an error
>> message proclaiming 'can not find channel named "1"'. This restores
>> invocation through sh -c.
>>     
>
> Are you using Tk 8.4 or 8.5?  The man pages for 8.5 imply that the
> 2>@1 form should work for all platforms, but maybe that wasn't true in
> 8.4.  If that's the case it's worth mentioning in the patch
> description.
>
> Paul.
>

Cygwin's Tcl/Tk is essentially frozen at 8.4.1. However, I really believe the problem is that the Tcl/Tk is not a full Cygwin application: it is mostly Windows, with only a few pieces converted to Posix through the cygwin.dll, so many things don't quite work correctly. For instance, the current gitk works fine under a pure Cygwin build of Tcl/Tk (8.4.13) I have locally. So, I believe the commit message I wrote is correct.

Mark