Re: [PATCH v2] Add support for GIT_CEILING_DIRS

From: David Reiss <dreiss@facebook.com>
Date: May 15, 2008, 07:11 UTC
Message-ID: <482BE238.5020309@facebook.com>
In-Reply-To: <482BE0EB.6040306@viscovery.net>

> If you make it so that the default value of ceil_offset is 0 (i.e. in the
> absence of any GIT_CEILING_DIRS),

This is what the new version of the patch does.

Show 5 quoted lines

> and at this place you did
> 
>                 } while (offset > ceil_offset && cwd[--offset] != '/');
> 
> you wouldn't have to bend backwards with this off-by-one magic, would you?

It seems like that would cause it to continue on with the outer loop, rather than aborting (which is what the current version does) when you hit the ceiling. Or maybe I'm misunderstanding something.

--David