Re: [PATCH 2/5] Make mktag a builtin.

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: May 12, 2008, 17:32 UTC
Message-ID: <48287F14.9040105@nrlssc.navy.mil>
In-Reply-To: <alpine.DEB.1.00.0805121803320.30431@racer>

Johannes Schindelin wrote:

Show 29 quoted lines

> Hi,
> 
> On Mon, 12 May 2008, Brandon Casey wrote:
> 
>> Junio C Hamano wrote:
>>> drafnel@gmail.com writes:
>>>
>>>> From: Brandon Casey <drafnel@gmail.com>
>>>>
>>>> Signed-off-by: Brandon Casey <drafnel@gmail.com>
>>>> @@ -306,6 +305,7 @@ BUILT_INS += git-fsck-objects$X
>>>>  BUILT_INS += git-get-tar-commit-id$X
>>>>  BUILT_INS += git-init$X
>>>>  BUILT_INS += git-merge-subtree$X
>>>> +BUILT_INS += git-mktag$X
>>>>  BUILT_INS += git-peek-remote$X
>>>>  BUILT_INS += git-repo-config$X
>>>>  BUILT_INS += git-show$X
>>>> @@ -423,6 +423,7 @@ LIB_OBJS += log-tree.o
>>>>  LIB_OBJS += mailmap.o
>>>>  LIB_OBJS += match-trees.o
>>>>  LIB_OBJS += merge-file.o
>>>> +LIB_OBJS += mktag.o
>>> This is unusual for a builtin.  Why didn't it migrate to builtin-mktag?
>> I didn't know how to do it.
>>
>> I was trying not to do a code move and a code change at the same time.
> 
> Why did you not consult Git's own history for guidance?  See e.g.

I did, but not exhaustively. I found only examples of converting a shell/perl script to a c version. That is straight-forward.

> 	$ git log next --diff-filter=A builtin-*.c

And indeed the first two results here are examples of converting scripts to builtin c versions.

The third result is applicable and converts merge-recursive from a standalone c version to builtin.

If I had known about (or looked for) the --diff-filter option I would have used the 'R' argument, since I am interested in a rename event, but it produces no results.

	$ git log next --diff-filter=R builtin-*.c

Adding -M does not help.

-brandon