git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: "make test" fails if /path/to/git.git contains spaces

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Apr 1, 2008, 06:29 UTC
Message-ID
<47F1D666.9060402@viscovery.net>
In-Reply-To
<3e8340490803311604v52ab9e03nd101ccadd4973760@mail.gmail.com>
Bryan Donlan schrieb:
Show 11 quoted lines
> On Mon, Mar 31, 2008 at 5:51 PM, Adam Roben <aroben@apple.com> wrote:
>>  Do we want to support having spaces in your path? It doesn't seem hard
>>  to fix, but it does seem like the kind of problem that will come up over
>>  and over again if only a very small set of people have this configuration.
> 
> Turns out that while trying to fix the tests, I've found that
> git-rebase doesn't like a $VISUAL having spaces, so perhaps this
> should be tested more often :) Or should we just require $VISUAL have
> no spaces?
> 
> I'll send a patch once I've got everything passing.

There was an attempt in the past to make this working. Please look at this (rather lengthy) thread, in particular, my critique on the patches that were submitted:

http://thread.gmane.org/gmane.comp.version-control.git/60544

I really would not like to see the same issues that I took the time to comment on to show up again.

-- Hannes
Previous: Bryan DonlanNext: Bryan Donlan
Message 3 of 4 in “"make test" fails if /path/to/git.git contains spaces”
  1. Adam RobenMar 31, 2008
  2. Bryan DonlanMar 31, 2008
  3. Johannes SixtApr 1, 2008
  4. Bryan DonlanApr 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.