Re: [EGIT PATCH 1/4] Change history page table to SWT.VIRTUAL.

From: Roger C. Soares <rogersoares@intelinet.com.br>
Date: Apr 1, 2008, 03:54 UTC
Message-ID: <47F1B1D9.3090209@intelinet.com.br>
In-Reply-To: <20080401033614.GP10274@spearce.org>

Shawn O. Pearce escreveu:

> So anyway, I see no breakage on Mac OS X or Win32 with your patch,
> and you said you tested it on Linux, so I'm going to include it.
> Thanks for figuring that one out, its a nice performance boost.
>

Cool.

Show 12 quoted lines

>> Maybe another option to try before leaving windows out is the 
>> ILazyContentProvider. Have you noticed that while GenerateHistoryJob is 
>> updating the table you can't use it? Because the input is regenerated 
>> every time, the table keeps going back to the first row.
>>     
>
> Hmm.  I didn't notice that, but at this point its so damn fast for
> me that I don't have the reflexes to really try and use the table
> before GenerateHistoryJob is complete.  I'll have to add some sleeps
> in there to make it slow down its work and see if I can reproduce
> what you are describing.
>

Yep, I noticed it while debuging and don't think it's very important. I'm very happy with the current speed and it's also almost instant to me. I think the lazy provider could be of some help in case someone is reading from a slow nfs partition or something like that. It's very border case thought.

[]s, Roger.