Re: git-submodule getting submodules from the parent repository
- From
Sam Vilain <sam@vilain.net>
- Date
- Mar 30, 2008, 20:19 UTC
- Message-ID
- <47EFF5BE.7030502@vilain.net>
- In-Reply-To
- <C38585A9-F09C-4A5B-8E72-6F3127DB2BB9@orakel.ntnu.no>
Eyvind Bernhardsen wrote:
Show 5 quoted lines
> Well, the point of "submodule push" was to avoid having to push in > each submodule manually; not enforcing the requirement that commits in > submodules must be publicly available before pushing from the main > module is a recipe for disaster, or at least annoyance. And nobody > likes an annoying git.
ok. so, refuse to push without forcing, don't do something dumb.
> Pushing to a branch works except that I couldn't figure out what to do > if the push doesn't succeed, ie, the branch has advanced on the remote > end.
It's simple. You just fail and tell the user what happened, and let them decide what to do.
> It's a reflog, not a branch, because a submodule can be changed to a > different branch, rewound, etc between commits in the main module; > there's no requirement that the old commit is in the new commit's > history.
If it is a rewind there is no issue, because you don't even need to push.
But again it comes back to - let the user sort it out, don't try to be too clever.
Sam.