Re: [PATCH v2 2/4] builtin-status: submodule summary support
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Mar 13, 2008, 14:11 UTC
- Message-ID
- <47D935FE.8010107@viscovery.net>
- In-Reply-To
- <1205416085-23431-3-git-send-email-pkufranky@gmail.com>
Ping Yin schrieb:
Show 7 quoted lines
> + memset(&sm_summary, 0, sizeof(sm_summary)); > + sm_summary.argv = argv; > + sm_summary.env = env; > + sm_summary.git_cmd = 1; > + sm_summary.no_stdin = 1; > + fflush(s->fp); > + sm_summary.out = dup(fileno(s->fp)); /* run_command closes it */
The fflush() at this point makes a lot of sense, and doesn't even need a comment (IMHO).
Show 5 quoted lines
> wt_status_print_changed(s); > + // must flush s->fp since following call will write to s->fp in a child process > + fflush(s->fp); > + wt_status_print_submodule_summary(s); > wt_status_print_untracked(s);
But then we don't need the fflush() here. Right?
-- Hannes