Re: [PATCH] show-ref: place angle brackets around variables in usage string

From: Philip Oakley <philipoakley@iee.org>
Date: Aug 29, 2015, 10:21 UTC
Message-ID: <47B9DE8756F943C0A0985F41D093340F@PhilipOakley>
In-Reply-To: <1440821924-4289-1-git-send-email-alexhenrie24@gmail.com>

From: "Alex Henrie" <alexhenrie24@gmail.com>

Show 17 quoted lines

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> builtin/show-ref.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/show-ref.c b/builtin/show-ref.c
> index dfbc314..131ef28 100644
> --- a/builtin/show-ref.c
> +++ b/builtin/show-ref.c
> @@ -8,7 +8,7 @@
>
> static const char * const show_ref_usage[] = {
>  N_("git show-ref [-q | --quiet] [--verify] [--head] [-d 
> | --dereference] [-s | --hash[=<n>]] [--abbrev[=<n>]] [--tags] 
> [--heads] [--] [<pattern>...]"),
> - N_("git show-ref --exclude-existing[=pattern] < ref-list"),
> + N_("git show-ref --exclude-existing[=<pattern>] < <ref-list>"),

Should the '<' stdin redirection be shown?

It looks (at first glance) as if this gained a double '< <' at the beginning of 'ref-list', rather than being a clean indication of the redirection. Perhaps change 'ref-list' to 'ref-list-file' for a slight improvement in clarity - this it's only occurance, and the redirection would best match a file.

Show 6 quoted lines

>  NULL
> };
>
> -- 
> 2.5.0
>

-- Philip (will be offline for 4 days)