Re: [PATCH] Remove useless if-before-free tests.

From

JHJean-Luc Herren <jlh@gmx.ch>

Date

Feb 18, 2008, 14:27 UTC

Message-ID

<47B995CC.2000809@gmx.ch>

In-Reply-To

<871w7bz1ly.fsf@rho.meyering.net>

Jim Meyering wrote:

> This change removes all useless if-before-free tests.
> E.g., it replace code like this
> 
> 	if (some_expression)
> 		free (some_expression);
> 
> with the now-equivalent
> 
> 	free (some_expression);

While you're at it, you might want to add this to your patch:

diff --git a/imap-send.c b/imap-send.c
index 9025d9a..3b27bca 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -472,7 +472,7 @@ v_issue_imap_cmd( imap_store_t *ctx, struct imap_cmd_cb *cb,
        if (socket_write( &imap->buf.sock, buf, bufl ) != bufl) {
                free( cmd->cmd );
                free( cmd );
-               if (cb && cb->data)
+               if (cb)
                        free( cb->data );
                return NULL;
        }

jlh