Re: [PATCH] git-cvsimport: Detect cvs without support for server mode

From: Jean-Luc Herren <jlh@gmx.ch>
Date: Feb 5, 2008, 13:03 UTC
Message-ID: <47A85EB7.2070105@gmx.ch>
In-Reply-To: <7vsl07epo5.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

> If we do not have cvs with server support, is there a fallback
> method we can still use to run cvsps?

I have no idea, I haven't looked at cvsps closely enough.

Show 17 quoted lines

> Jean-Luc Herren <jlh@gmx.ch> writes:
>> diff --git a/t/t9600-cvsimport.sh b/t/t9600-cvsimport.sh
>> index 7706430..d8cbfd0 100755
>> --- a/t/t9600-cvsimport.sh
>> +++ b/t/t9600-cvsimport.sh
>> @@ -10,6 +10,13 @@ then
>>  	exit
>>  fi
>>  
>> +if echo -n | cvs server 2>&1 | grep 'Unknown command' > /dev/null
>> +then
>> +	say 'skipping cvsimport tests, cvs has support for server mode'
>> +	test_done
>> +	exit
>> +fi
> 
> Do you mean "has to support server" or "does not have support for"?

I meant to say "cvs has no support for server mode", but I think "doesn't have support for" is better.

jlh