Re: Trying to get GIT running on SCO OpenServer
Show 18 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> FWIW we had the same problem in MinGW, and Hannes Sixt solved it:
>>
>> http://repo.or.cz/w/git/mingw/j6t.git?a=commitdiff;h=b8e84a68f01a2386b2071e1bdc8e24de809a3f6d
>>
>> That might give you an idea how to solve the issue. Maybe you even make a
>> git patch out of it? With a Makefile variable BROKEN_SNPRINTF=YesPlease,
>> maybe?
>
> Hmmm. Looking at that change makes me wonder if that solution
> is Kosher. The value of the va_list you pass to vsnprintf() is
> unspecified after the call.
>
> It may be Ok as mingw-only "compatibility wrapper", but I think
> you have to be a bit careful. It is not a general solution for
> any BROKEN_SNPRINTF.
>
That's what va_copy() is for.
-hpa