Re: [PATCH] HP-UX does not have select.h

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Dec 18, 2007, 08:16 UTC
Message-ID: <476781C6.6050507@viscovery.net>
In-Reply-To: <7vbq8o370k.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 18 quoted lines

> "H.Merijn Brand" <h.m.brand@xs4all.nl> writes:
> 
>> On Mon, 17 Dec 2007 13:00:22 -0800, Junio C Hamano <gitster@pobox.com> wrote:
>>
>>> "H.Merijn Brand" <h.m.brand@xs4all.nl> writes:
>>>
>>>> HP-UX does not have select.h, but it offers all select () functionality.
>>>> The defines are in <sys/types.h> and <X11/fd.h>
>>> Will apply the patch as-is for now, only because I do not want major
>>> surgery during rc period, but I think is can be improved.
>> ...
>>> Besides, isn't _HPUX_SOURCE a feature-test macro?  Feature test macros
>> That is defined in GNU gcc. I did not pass it with -D...
> 
> Actually I changed my mind.  I won't be applying this as is.
> 
> For the selective inclusion of <sys/select.h>, I would prefer it see it
> done like the attached.

Is select() actually needed? The one instance in pager.c can easily be replaced by poll(), which I've already done in my own tree. The other one in http.c is only used as a timer, but I don't know how to get rid of that. Maybe a setitimer()/pause() combo?

-- Hannes