Re: how to create v2 patch

From: Andreas Ericsson <ae@op5.se>
Date: Dec 6, 2007, 22:03 UTC
Message-ID: <4758719F.1080408@op5.se>
In-Reply-To: <475855D6.201@imap.cc>

Tilman Schmidt wrote:

Show 17 quoted lines

> Am 01.12.2007 14:43 schrieb Mike Hommey:
>> On Sat, Dec 01, 2007 at 02:17:39PM +0100, Pascal Obry wrote:
>>> Tilman Schmidt a écrit :
>>>> I have produced a patch, submitted it to LKML, received a few
>>>> comments, committed appropriate changes to my local git tree,
>>>> and now want to submit a revised patch. How do I do that?
>>>> If I just run git-format-patch again, it produces my original
>>>> patch plus a second one containing my updates, but what I need
>>>> is a single new patch replacing the first one.
>>> Can't you merge both of your changes in your local repository? I would
>>> do that with an interactive rebase.
>> Or just git commit --amend when committing.
> 
> Hmm. But wouldn't each of these approaches lead to my original
> commit being removed from my git repository? And isn't removing
> commits that have already been published strongly discouraged?
>

The term "published" means different things for different projects. For the Linux kernel, "published" is when your commit ends up in a repository that Linus pulls from.

So long as you're getting suggestions to fix up your patch, it's safe to assume it hasn't been accepted into one of those repos, and you can safely --amend the offending commit(s).

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231