git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fix UTF Encoding issue

From
Benjamin Close <benjamin.close@clearchain.com>
Date
Dec 3, 2007, 21:46 UTC
Message-ID
<47547930.5070603@clearchain.com>
In-Reply-To
<200712031802.55514.jnareb@gmail.com>
Jakub Narebski wrote:
Show 25 quoted lines
> On Mon, 3 Dec 2007, Martin Koegler wrote:
>   
>> On Mon, Dec 03, 2007 at 04:06:48AM -0800, Jakub Narebski wrote:
>>     
>>> Ismail Dönmez <ismail@pardus.org.tr> writes:
>>>       
>>>> Monday 03 December 2007 Tarihinde 12:14:43 yazm??t?:
>>>>         
>>>>> Benjamin Close <Benjamin.Close@clearchain.com> writes:
>>>>>           
>>>>>> -	eval { $res = decode_utf8($str, Encode::FB_CROAK); };
>>>>>> -	if (defined $res) {
>>>>>> -		return $res;
>>>>>> -	} else {
>>>>>> -		return decode($fallback_encoding, $str, Encode::FB_DEFAULT);
>>>>>> -	}
>>>>>> +	eval { return ($res = decode_utf8($str, Encode::FB_CROAK)); };
>>>>>> +	return decode($fallback_encoding, $str, Encode::FB_DEFAULT);
>>>>>>  }
>>>>>>             
>> This version is broken on Debian sarge and etch. Feeding a UTF-8 and a latin1
>> encoding of the same character sequence yields to different results.
>>     
>
>   
For the record, this was on a debian sid machine.

#perl --version This is perl, v5.8.8 built for x86_64-linux-gnu-thread-multi

and the result of not using the original patch was:

<h1>Software error:</h1> <pre>Cannot decode string with wide characters at /usr/lib/perl/5.8/Encode.pm line 166. </pre>

I haven't tried the other solutions tested here.
Show 27 quoted lines
>> eval { $res = decode_utf8(...); }
>> if ($@) 
>>      return decode(...);
>> return $res
>>
>> or
>>
>> eval { $res = decode_utf8(...); }
>> if (defined $res)
>>       return $res;
>> else
>>     return decode(...);
>>
>> show the same (wrong) behaviour on Debian sarge. They do not always
>> decode non UTF-8 characters correctly, eg.
>> #öäü does not work
>> #äöüä does work
>>
>> On Debian etch, both versions are working.
>>     
>
> I don't know enough Perl to decide if it is a bug in gitweb usage
> of decode_utf8, if it is a bug in your version of Encode, or if it
> is bug in Encode.
>
> Send copy of this mail to maintainers of Encode perl module.
>   
Ismail do you know if sid was also broken?
Previous: Jakub NarebskiNext: Ismail Dönmez
Message 7 of 24 in “Fix UTF Encoding issue”
  1. Benjamin CloseDec 3, 2007
  2. Junio C HamanoDec 3, 2007
  3. Ismail DönmezDec 3, 2007
  4. Jakub NarebskiDec 3, 2007
  5. Martin KoeglerDec 3, 2007
  6. Jakub NarebskiDec 3, 2007
  7. Benjamin CloseDec 3, 2007
  8. Ismail DönmezDec 3, 2007
  9. Benjamin CloseDec 3, 2007
  10. Jakub NarebskiDec 3, 2007
  11. Ismail DönmezDec 4, 2007
  12. Martin KoeglerDec 4, 2007
  13. Ismail DönmezDec 4, 2007
  14. Martin KoeglerDec 4, 2007
  15. Martin KoeglerDec 4, 2007
  16. Ismail DönmezDec 4, 2007
  17. Martin KoeglerDec 4, 2007
  18. Ismail DönmezDec 4, 2007
  19. Ismail DönmezDec 4, 2007
  20. Martin KoeglerDec 4, 2007
  21. Ismail DönmezDec 4, 2007
  22. Ismail DönmezDec 4, 2007
  23. Jakub NarebskiDec 4, 2007
  24. Wincent ColaiutaDec 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.