Re: [PATCH] Allow HTTP proxy to be overridden in config

From: Sam Vilain <sam.vilain@catalyst.net.nz>
Date: Nov 23, 2007, 03:35 UTC
Message-ID: <47464A90.4030509@catalyst.net.nz>
In-Reply-To: <7voddl24b7.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 15 quoted lines

>> The http_proxy / HTTPS_PROXY variables used by curl to control
>> proxying may not be suitable for git.  Allow the user to override them
>> in the configuration file.
>> ---
>>   In particular, privoxy will block directories called /ad/ ... d'oh!
>> +++ b/Documentation/config.txt
>> +http.proxy::
>> +	Override the HTTP proxy, normally configured using the 'http_proxy'
>> +	environment variable (see gitlink:curl[1]).
> 
> This may work around the issue you cited, but it makes me wonder
> if it is a road to insanity.  Does the curl library expect that
> (1) each and every HTTP talking application that uses the
> library offer this kind of knob for its users to tweak, and (2)
> users set the knob for each and every one of such application?

This is true. However I still think that it is a useful feature for many users, with few side effects. If nothing else the bit on the man page will prompt them to think, "oh, I should set that in the environment".

Show 5 quoted lines

> I would say if privoxy cannot be tweaked to allow /ad/ in chosen
> context (e.g. /ad/ in general is rejected but /objects/ad/ is
> Ok), that is what needs to be fixed.
> Or it would be the use of such a broken proxy by the user.  That
> can be fixed and much easily.

Yes - but consider the dilemma of the user. They've apt-get installed this privoxy thing and figured out how to set their applications to use it. Now, it doesn't work and they think it is the proxy in the way, and they've no idea that they might be able to reconfigure it. This way they can tell git to bypass it.

I don't know, I see your point and pretty much agree with it. It just seems like something that might come in handy (as well as be another vector for something you need to check when you get HTTP fetch issues - so maybe a command-line option would be better).

Actually something that would really have helped is more documentation of the various GIT_CURL_* environment variables available for debugging.

-- 
Sam Vilain, Chief Yak Shaver, Catalyst IT (NZ) Ltd.
phone: +64 4 499 2267        PGP ID: 0x66B25843