git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Git.pm: Don't return 'undef' in vector context.

From
DZDan Zwell <dzwell@gmail.com>
Date
Nov 17, 2007, 03:20 UTC
Message-ID
<473E5E08.2090609@zwell.net>
In-Reply-To
<fhjl70$db4$1@ger.gmane.org>
Jakub Narebski wrote:
Show 6 quoted lines
> 
> By the way, what do you think about changing Git.pm config handling
> to the 'eager' one used currently by gitweb, namely reading all the
> config to hash, and later getting config values from hash instead of
> calling git-config? Or at least make it an option?
>

That seems appropriate, though it may be a slight trade-off between complexity and efficiency. I don't think it's strictly necessary, at least for git-add--interactive. My experience is that the nine calls to config() (that I am adding) do not slow down the program from a user perspective (though I haven't tested on a slower computer).

The big reason to do it would be if you wanted to convert gitweb to use the standard config() call from Git.pm. Because right now, config() isn't efficient, but it probably doesn't need to be.

Dan
Previous: Jakub NarebskiNext: Jakub Narebski
Message 7 of 8 in “Git.pm: Don't return 'undef' in vector context.”
  1. Git.pm: Don't return 'undef' in vector context.Dan Zwell, Nov 16, 2007
  2. Junio C HamanoNov 16, 2007
  3. Dan ZwellNov 16, 2007
  4. Junio C HamanoNov 17, 2007
  5. Sebastian HarlNov 16, 2007
  6. Jakub NarebskiNov 16, 2007
  7. Dan ZwellNov 17, 2007
  8. Jakub NarebskiNov 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.