Re: [PATCH] diffcore: Allow users to decide what funcname to use

From: Andreas Ericsson <ae@op5.se>
Date: Nov 13, 2007, 10:07 UTC
Message-ID: <47397763.6080307@op5.se>
In-Reply-To: <fhbsor$ebf$1@ger.gmane.org>

Jakub Narebski wrote:

Show 14 quoted lines

> Andreas Ericsson wrote:
> 
>> Git can be smarter than that, and imo it should. This
>> patch lets the diffcore grok a new configuration variable,
>> "diff.funcnames", which can be set to "new", "old", or a
>> boolean value, which will cause it to be "old" (for 'true')
>> and 'none' (for 'false').
> 
> Wouldn't it be better to use existing 'diff driver' infrastructure
> for this? See "Defining a custom hunk-header" section in
> gitattributes(5).
> 
> On the other hand... no.
>

It's impossible to do that, since that driver will only ever be fed the "old" file with the old code. I'm guessing you noticed that yourself, so just explaining in case anyone else wonders.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231