git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] launch_editor(): read the file, even when EDITOR=:

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Nov 8, 2007, 12:33 UTC
Message-ID
<47330222.7000206@viscovery.net>
In-Reply-To
<Pine.LNX.4.64.0711081215360.4362@racer.site>
Johannes Schindelin schrieb:
Show 8 quoted lines
> +		struct child_process child;
> +		memset(&child, 0, sizeof(child));
> +		child.argv = args;
> +		args[0] = editor;
> +		args[1] = path;
> +		args[2] = NULL;
>  
> +		if (run_command(&child))
You can shorten this to
		const char *args[] = { editor, path, NULL };
		if (run_command_v_opt(args, 0))
(and possibly remove 'args' that is in the surrounding block).
-- Hannes
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 4 of 13 in “builtin-commit fixes”
  1. 0/3 builtin-commit fixesJohannes Schindelin, Nov 8, 2007
  2. 1/3 builtin-commit: fix reflog message generationJohannes Schindelin, Nov 8, 2007
  3. 2/3 launch_editor(): read the file, even when EDITOR=:Johannes Schindelin, Nov 8, 2007
  4. Johannes SixtNov 8, 2007
  5. 2/3 launch_editor(): read the file, even when EDITOR=:Johannes Schindelin, Nov 8, 2007
  6. 3/3 builtin-commit: fix author date with --amend --author=<author>Johannes Schindelin, Nov 8, 2007
  7. 4/3 t3700: avoid racy git situationJohannes Schindelin, Nov 8, 2007
  8. Johannes SixtNov 8, 2007
  9. Johannes SchindelinNov 8, 2007
  10. Kristian HøgsbergNov 8, 2007
  11. Johannes SixtNov 8, 2007
  12. Junio C HamanoNov 8, 2007
  13. Johannes SchindelinNov 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.