Re: [PATCH] contrib/hooks/post-receive-email: add a From: line to the email header

From: Andreas Ericsson <ae@op5.se>
Date: Nov 8, 2007, 10:35 UTC
Message-ID: <4732E657.7020202@op5.se>
In-Reply-To: <7vode52hag.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 8 quoted lines

> Gerrit Pape <pape@smarden.org> writes:
> 
>> $committer is already extracted from the latest existing rev, so add the
>> corresponding From: line to the email header.
> 
> You may fight this out with Andy if you want to, but I think I'd
> side with the existing behaviour.
>

I'm with Andy here, for the reasons stated below.

Show 12 quoted lines

> commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b
> Author: Andy Parkins <andyparkins@gmail.com>
> Date:   Fri Sep 28 15:24:26 2007 +0100
> 
>     post-receive-hook: Remove the From field from the generated email header so that the pusher's name is used
>     
>     Using the name of the committer of the revision at the tip of the
>     updated ref is not sensible.  That information is available in the email
>     itself should it be wanted, and by supplying a "From", we were
>     effectively hiding the person who performed the push - which is useful
>     information in itself.
>

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231