Re: [PATCH] gc: use parse_options
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Nov 5, 2007, 23:08 UTC
- Message-ID
- <472FA26E.4060706@nrlssc.navy.mil>
- In-Reply-To
- <7vhck579pm.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
Show 6 quoted lines
> James Bowes <jbowes@dangerouslyinc.com> writes:
>
>> + struct option builtin_gc_options[] = {
>> + OPT_BOOLEAN(0, "prune", &prune, "prune unused objects"),
>
> I would write "unreferenced loose" instead of "unused" here...It is not just "loose" objects here, but also unreferenced objects in packs, since the "-a" option to repack is now only used when --prune is specified. Without --prune, "-A" is supplied to repack instead.
So maybe the message should just be "prune unreferenced objects"
-brandon