Re: [PATCH 3/5] pretty describe: move library functions to the new file describe.c

From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Nov 4, 2007, 14:56 UTC
Message-ID: <472DDD80.2010203@lsrfire.ath.cx>
In-Reply-To: <Pine.LNX.4.64.0711041435540.4362@racer.site>

Johannes Schindelin schrieb:

Show 12 quoted lines

> Hi,
> 
> On Sun, 4 Nov 2007, Ren? Scharfe wrote:
> 
>>  Makefile           |    2 +-
>>  builtin-describe.c |  202 ---------------------------------------------------
>>  cache.h            |    5 ++
>>  describe.c         |  204 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 210 insertions(+), 203 deletions(-)
>>  create mode 100644 describe.c
> 
> Would not "format-patch -C -C" have given a nicer output?

Yes, it would have been shorter, but it looks a bit strange, because it's deleting stuff from the new file describe.c (i.e. all the things left in builtin-describe.c):

 Makefile                         |    2 +-
 builtin-describe.c               |  202 --------------------------------------
 cache.h                          |    5 +
 builtin-describe.c => describe.c |   85 ----------------
 4 files changed, 6 insertions(+), 288 deletions(-)
 copy builtin-describe.c => describe.c (66%)

That's 367 lines of patch + stat vs. 470 lines for the one I sent. Will use next time.

Thanks, René