Re: Why is --pretty=format: so slow?

From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Nov 4, 2007, 13:53 UTC
Message-ID: <472DCEE3.501@lsrfire.ath.cx>
In-Reply-To: <7vhck2s02z.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 11 quoted lines

> René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> 
>> Incidentally, I'm finishing a patch series to add git-describe
>> style placeholders.  It needs such an optimization even more badly
>> (and has it).  Speeding up other slow placeholder expansions falls
>> out quite naturally.  Please wait just a few minutes..
> 
> Thanks, and take your time, as I am just going to bed, dreaming for a
> perfect series from one of the few people on this list whose patches
> I do not have to read to reject crap, but I do read to get impressed
> and admire ;-)

*blushes*

Well, it's certainly not perfect -- I just noticed I've sent the patches to your old address. Would you like me to resend them?

And, of course, I found a conceptual bug (which is impossible to trigger with the current code, fortunately), while looking over the changes a last time. *sigh*. I'll send a fix right away.

René