Re: [PATCH 1/2] War on whitespace: first, a bit of retreat.

From: Andreas Ericsson <ae@op5.se>
Date: Nov 2, 2007, 10:45 UTC
Message-ID: <472AFFE4.9060004@op5.se>
In-Reply-To: <ee77f5c20711020314h43290dbs8141cb3905c867@mail.gmail.com>

David Symonds wrote:

Show 17 quoted lines

> On 11/2/07, Junio C Hamano <gitster@pobox.com> wrote:
>> This introduces core.whitespace configuration variable that lets
>> you specify the definition of "whitespace error".
>>
>> Currently there are two kinds of whitespace errors defined:
>>
>>  * trailing-space: trailing whitespaces at the end of the line.
>>
>>  * space-before-tab: a SP appears immediately before HT in the
>>    indent part of the line.
> 
>>         [core]
>>                 whitespace = -trailing-space
> 
> Could I suggest naming the option 'whitespaceError', so it's clearer
> that it's a negative setting?
>

Which would also open the window for "WhitespaceWarning" and "WhitespaceAutofix" later on, using the same semantics. Personally, I'd like to get warnings for non-tab-indent^H^H^H indent-with-non-tab (rename that option, perhaps?), autofix for trailing-whitespace and errors for space-before-tab, with command-line switch to override config settings.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231