Re: Bug in fetch-pack.c, please confirm

From: Kyle J. McKay <mackyle@gmail.com>
Date: Mar 15, 2015, 22:21 UTC
Message-ID: <471A97CA-0004-48F7-B6C9-50266EE370D4@gmail.com>
In-Reply-To: <xmqq3856vhtt.fsf@gitster.dls.corp.google.com>

On Mar 15, 2015, at 00:30, Junio C Hamano wrote:

Show 26 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> "Kyle J. McKay" <mackyle@gmail.com> writes:
>>
>>> Hi guys,
>>>
>>> So I was looking at fetch-pack.c (from master @ 52cae643, but I  
>>> think
>>> it's the same everywhere):
>>>
>> ...
>>> -		hashcpy(ref->new_sha1, local);
>>> +		hashcpy(ref->new_sha1, o->sha1);
>>> 		if (!args->verbose)
>>> 			continue;
>>> 		fprintf(stderr,
>>> 			"already have %s (%s)\n", sha1_to_hex(remote),
>>> 			ref->name);
>>> 	}
>>> 	return retval;
>>> ---
>
> One thing I wonder is if this hashcpy() is doing anything useful,
> though.  Is ref->new_sha1 used after we are done in this codepath,
> or is the reason nobody noticed it is because it does not matter
> whatever garbage is in that field nobody looks at it?

My thoughts exactly. hence the "please confirm" request. I'm not familiar enough with the fetch pack code to know the answer off the top of my head. I was hoping someone else who's been in the fetch pack code recently (*Hi Peff*) might just already know. :)