Re: [PATCH] exec_git_cmd: fix executing commands if path contains spaces

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 10, 2007, 06:16 UTC
Message-ID: <470C6E58.3080208@viscovery.net>
In-Reply-To: <11919659771056-git-send-email-prohaska@zib.de>

Steffen Prohaska schrieb:

Show 5 quoted lines

> Ok, this is what I created from the quick-fix. It works for
> me in msysgit. 
> 
> Should the patch be polished that it can be applied to git.git
> or will we only apply it to 4msysgit?

I'll apply it to mingw.git, and as long as you don't rebase or pull from there, you'd also have to apply it to 4msysgit.

git.git is a no-go at this time - compat/mingw.c doesn't exist, yet.

> If it should be polished, what would be the right way?
> ifdef in exec_cmd.c?

This area needs more polishing, and it will be among the *last* mingw patches that flow upstream.

BTW, I think the fix is incomplete anyway: We quote only argv[0], but actually all of argv should be quoted. Will test.

-- Hannes