Re: [AGGREGATED PATCH] Fix in-place editing functions in convert.c

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 5, 2007, 09:24 UTC
Message-ID: <470602B1.8090706@viscovery.net>
In-Reply-To: <20071005085522.32EFF1E16E@madism.org>

Pierre Habouzit schrieb:

Show 14 quoted lines

> @@ -281,20 +283,19 @@ static int apply_filter(const char *path, const char *src, size_t len,
>  		ret = 0;
>  	}
>  	if (close(pipe_feed[0])) {
> -		ret = error("read from external filter %s failed", cmd);
> +		error("read from external filter %s failed", cmd);
>  		ret = 0;
>  	}
>  	status = finish_command(&child_process);
>  	if (status) {
> -		ret = error("external filter %s failed %d", cmd, -status);
> +		error("external filter %s failed %d", cmd, -status);
>  		ret = 0;
>  	}

If you want to, you can leave away these cosmetical corrections since I'm working on a patch that replaces this entire passus. (Will be needed for the MinGW port).

-- Hannes