Re: [PATCH 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone
On Tue, Apr 22, 2008 at 3:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> "Ping Yin" <pkufranky@gmail.com> writes:
>
>
> > I just want to unify the behaviour of handling relative url.
> >
> > 'git submodule add' treats './foo' and 'foo' as different urls. The
> > 1st one is relative to remote.origin.url, while the 2nd one is
> > relative the current directory. I think this kind of behaviour is
> > better for submodules, so i unify the handling of relative urls as
> > this.
> >
> > With this kind of behaviour, i can set 'submodule.foo.url=./foo' in
> > .gitmodules or $GIT_DIR/config. And when remote.origin.url changes, i
> > have not to change submodule.foo.url if the super project and
> > submodule foo are always located on the same central host.
>
> Please have that kind of justification in the proposed commit log message.
> When these changes are made into history, people cannot ask you questions
> like I did and expect the history to produce such answer on demand ;-)
>
OK, i'll resend this patch tonight.
--
Ping Yin