Re: Re* [PATCH] git-submodule: Don't blame when git-describe fails

From: Ping Yin <pkufranky@gmail.com>
Date: Mar 2, 2008, 17:17 UTC
Message-ID: <46dff0320803020917s154c204cl56d85e47de892173@mail.gmail.com>
In-Reply-To: <7vy791oyqa.fsf@gitster.siamese.dyndns.org>

On 3/3/08, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Ping Yin <pkufranky@gmail.com> writes:
>
> > Avoid 'fatal: cannot describe' message
> >
> > Signed-off-by: Ping Yin <pkufranky@gmail.com>
>
> I see you reworded the commit log somewhat in your second attempt.  I
> would have written it this way, though:
>
>    git-submodule: Avoid 'fatal: cannot describe' message
>
>    When "git submodule status" command tries to show the name of the
>    submodule HEAD revision more descriptively, but the submodule
>    repository lacked a suitable tag to do so, it leaked "fatal: cannot
>    describe" message to the UI.  Squelch it.
>

That's ok. You can sign off it.

-- 
Ping Yin