git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] git-cvsserver: Add support for some binary files

From
Martin Langhoff <martin.langhoff@gmail.com>
Date
May 18, 2008, 22:38 UTC
Message-ID
<46a038f90805181538v56aee5b8y33d68b226a62494f@mail.gmail.com>
In-Reply-To
<7v7idteqzn.fsf@gitster.siamese.dyndns.org>
On Sat, May 17, 2008 at 12:03 PM, Junio C Hamano <junio@pobox.com> wrote:
Show 9 quoted lines
> Matthew Ogilvie <mmogilvi_git@miniinfo.net> writes:
>
>> This series of patches extends git-cvsserver to support telling the
>> CVS client to set the -kb (binary) mode for files that git considers
>> to be binary (and not for text files).  It includes updates to
>> documentation and tests.
>
> I am unfortunately not familiar with this part of the system and I'd need
> to summon help from experts, but it looks rather nicely done.
Looks good.

I was at first a bit troubled - "cvsserver doesn't do keyword expansion anyway" was my first thought - but it makes sense to have this to help newline-munging clients.

IIRC, one thing that is _not_ handled well in CVS -k flag changes on the server side (since -k modes are not versioned). If we are guessing, this may be more likely to happen, or at least more likely to _surprise_ people.

Matthew, have you had a chance to test k mode changes against clients? Are we reasonably bug-compatible with the original turd^H^H^Hhing? ;-)

Sorry about the latency!
cheers,
m
-- 
 martin.langhoff@gmail.com
 martin@laptop.org -- School Server Architect
 - ask interesting questions
 - don't get distracted with shiny stuff - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff
Previous: Matthew OgilvieNext: Matthew Ogilvie
Message 7 of 11 in “git-cvsserver: Add support for some binary files”
  1. 0/3 git-cvsserver: Add support for some binary filesMatthew Ogilvie, May 15, 2008
  2. 1/3 git-cvsserver: add mechanism for managing working tree and current directoryMatthew Ogilvie, May 15, 2008
  3. 2/3 implement gitcvs.usecrlfattrMatthew Ogilvie, May 15, 2008
  4. 3/3 git-cvsserver: add ability to guess -kb from contentsMatthew Ogilvie, May 15, 2008
  5. Junio C HamanoMay 17, 2008
  6. Matthew OgilvieMay 18, 2008
  7. Martin LanghoffMay 18, 2008
  8. Matthew OgilvieMay 19, 2008
  9. Johannes SchindelinMay 19, 2008
  10. Matthew OgilvieMay 20, 2008
  11. Martin LanghoffMay 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.