Re: cvs importer woes

From: Martin Langhoff <martin.langhoff@gmail.com>
Date: Jun 27, 2006, 10:42 UTC
Message-ID: <46a038f90606270342k2288cc2ds34ae05e089b8c906@mail.gmail.com>
In-Reply-To: <44A102F0.9090604@op5.se>

On 6/27/06, Andreas Ericsson <ae@op5.se> wrote:

> Sadly, the cvsimport command no longer works to create new repositories
> from scratch.

We are seeing some breakage in cvsimport that started with a patch of mine:

 8f732649bc4d5619a1b399e5808b3f4c662ad200 cvsimport: keep one index
per branch during import

so I'd say that if you are using cvsimport, stick to the v1.4.0 version. You can do

  git-cat-file blob v1.4.0:git-cvsimport.perl >git-cvsimport.perl

> problem seems to be firstly 061303f0b50a648db8e0af23791fc56181f6bf93.

Yes, that commit will break brand new imports, but it's trying to fixup breakage that started with my patch. It shouldn't be too hard to fix up, but real life is interfering.

> Oh, now it's done (4 minutes for 620 revisions with automated testing
> between good/bad. *LOVE* bisect).

Love bisect too for easy-to-test cases.

> The culprit is definitely 061303f0b50a648db8e0af23791fc56181f6bf93.
>
> Any perl-literate takers? Otherwise, just reverting the patch makes
> things work (for me) again.

Don't just revert that patch, unless I'm wrong there is some subtle branch-creation breakage too.

cheers,

martin