git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: handle changed svn command-line syntax

From
Sam Vilain <sam@vilain.net>
Date
Sep 21, 2007, 03:27 UTC
Message-ID
<46F33A05.2000906@vilain.net>
In-Reply-To
<46F33734.3080408@vilain.net>
Sam Vilain wrote:
Show 9 quoted lines
> Sam Vilain wrote:
>> Previously, if you passed a revision and a path to svn, it meant to look
>> back at that revision and select that path.  New behaviour is to get the
>> path then go back to the revision.  The old syntax is selected with new
>> syntax PATH@REV.  This new syntax is not supported by the old tools, so we
>> have to try both in turn.
> 
> Blast, this analysis is wrong.  Hold off, I'll see what's really going
> on and re-submit.
ok, figured it out :)
I was close!  I was just thrown off by 'svn ls PATH@REV'
The patch is the same, just the description has changed.
Subject: [PATCH] git-svn: handle changed svn cp command-line syntax
Previously, if you passed a revision and a path to svn cp, it meant to look
back at that revision and select that path.  New behaviour is to get the
path then go back to the revision (like other commands that accept @REV
or -rREV do).  The more consistent syntax is not supported by the old
tools, so we have to try both in turn.
---
 t/t9104-git-svn-follow-parent.sh |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t9104-git-svn-follow-parent.sh b/t/t9104-git-svn-follow-parent.sh
index 9eab945..7ba7630 100755
--- a/t/t9104-git-svn-follow-parent.sh
+++ b/t/t9104-git-svn-follow-parent.sh
@@ -51,8 +51,10 @@ test_expect_success 'init and fetch from one svn-remote' "
         "
 
 test_expect_success 'follow deleted parent' "
-        svn cp -m 'resurrecting trunk as junk' \
-               -r2 $svnrepo/trunk $svnrepo/junk &&
+        (svn cp -m 'resurrecting trunk as junk' \
+               $svnrepo/trunk@2 $svnrepo/junk ||
+         svn cp -m 'resurrecting trunk as junk' \
+               -r2 $svnrepo/trunk $svnrepo/junk) &&
         git config --add svn-remote.svn.fetch \
           junk:refs/remotes/svn/junk &&
         git-svn fetch -i svn/thunk &&
-- 
1.5.3.2.3.g2f2dcc-dirty
Previous: Sam VilainNext: Eric Wong
Message 6 of 9 in “git-svn: pass tests on svn trunk”
  1. 0/3 git-svn: pass tests on svn trunkSam Vilain, Sep 21, 2007
  2. git-svn: fix test for trunk svn (commit message not needed)Sam Vilain, Sep 21, 2007
  3. git-svn: fix test for trunk svn (transaction out of date)Sam Vilain, Sep 21, 2007
  4. git-svn: handle changed svn command-line syntaxSam Vilain, Sep 21, 2007
  5. Sam VilainSep 21, 2007
  6. Sam VilainSep 21, 2007
  7. Eric WongSep 21, 2007
  8. Karl HasselströmSep 22, 2007
  9. Eric WongSep 21, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.