git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] Export format_commit_message()

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Sep 3, 2007, 18:44 UTC
Message-ID
<46DC55FA.6040905@lsrfire.ath.cx>
In-Reply-To
<Pine.LNX.4.64.0709031934480.28586@racer.site>
Johannes Schindelin schrieb:
Show 9 quoted lines
>> -static long format_commit_message(const struct commit *commit,
>> -		const char *msg, char **buf_p, unsigned long *space_p)
>> +long format_commit_message(const struct commit *commit, const void *template,
>> +                           char **buf_p, unsigned long *space_p)
> 
> I am quite sure that this breaks compilation in C++.
> 
> Besides, "format" is so much more descriptive here IMHO.  What is so wrong 
> with "format" for you?

I have nothing against naming the parameter "format", actually. This name simply didn't occur to me -- weird but true. :-]

René
Previous: Johannes Schindelin
Message 3 of 3 in “Export format_commit_message()”
  1. 1/3 Export format_commit_message()René Scharfe, Sep 3, 2007
  2. Johannes SchindelinSep 3, 2007
  3. René ScharfeSep 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.