Re: [PATCH] autodetect core.symlinks in git-init
- From
Marius Storm-Olsen <marius@trolltech.com>
- Date
- Aug 31, 2007, 08:23 UTC
- Message-ID
- <46D7CFE5.9040508@trolltech.com>
- In-Reply-To
- <7vodgo2moe.fsf_-_@gitster.siamese.dyndns.org>
Junio C Hamano said the following on 31.08.2007 09:22:
Show 7 quoted lines
> We already autodetect if filemode is reliable on the filesystem > to deal with VFAT and friends. Do the same for symbolic link > support. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > + if (!close(xmkstemp(path)) &&
Just tried this with 4msysgit (so, MinGW on Windows), and with a patch for adding xmkstemp() to git-compat-util.h, this patch works perfectly on Windows. It's obviously the right thing to do.
Acked-by: Marius Storm-Olsen <mstormo_git@storm-olsen.com>
-- .marius