Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

From: Rene Herman <rene.herman@gmail.com>
Date: Aug 14, 2007, 18:03 UTC
Message-ID: <46C1EE6F.2080807@gmail.com>
In-Reply-To: <1187110824.32555.76.camel@localhost>

On 08/14/2007 07:00 PM, Joe Perches wrote:

> On Tue, 2007-08-14 at 17:53 +0200, Rene Herman wrote:

Show 9 quoted lines

>> It isn't about MODULE_FOO() tags, it is about tagging /source/ files 
>> to help with putting CCs on patch submissals.
>> If we want to link source file foo.c and the 
>> MAINTAINERS information, we have 3 options:
>> 1. MAINTAINERS --> foo.c
>> 2. foo.c --> MAINTAINERS
>> 3. foo.c <--> some 3rd file <--> MAINTAINERS
> 
> I added git@vger.kernel.org and Junio Hamano

Well, yes, I agree -- going through GIT seems to be the only really workable solution.

That is, instead of (case 2, you snipped it) having a backlink to the MAINTAINERS file in a header inside the source GIT would maintain this backlink -- and at that point, you can basically forego the MAINTAINERS file completely other than as something GIT can generate and just regard all of it meta-information (you may want to generate MAINTAINERS for releases but making GIT the source is the idea).

"git info --maintainer drivers/ide/ide-cd.c" or some such would say "Alan Cox <alan@...>".

There are more possibilities for this kind of meta information. git info --author, git info --license, git info --whatever. Given that it's intended for developers, needing GIT should not get in the way but there's always the generated MAINTAINERS file in releases as well.

It would ofcourse automatically stay up to date through deleting and moving of files. You'd probably want to devise a way to enable a submitter to also automatically provide meta-information upon addition of files. This can be done in the same way as a "Signed-off-by". Just tags in a submit email.

This should probably turn out to be the way things work yes. The paths in the MAINTAINERS file grow stale, source headers might also and sticking headers on every source file isn't nice anyway -- it's meta-information and the SCM can maintain it.

Rene.