git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: fix commiting renames over DAV with funky file names

From
RDRogan Dawes <lists@dawes.za.net>
Date
Jul 16, 2007, 06:36 UTC
Message-ID
<469B11EB.8020003@dawes.za.net>
In-Reply-To
<20070716045350.GA15307@mayonaise>
Eric Wong wrote:
Show 31 quoted lines
> Renaming files with non-URI friendly characters caused
> breakage when committing to DAV repositories (over http(s)).
> 
> Even if I try leaving out the $self->{url} from the return value
> of url_path(), a partial (without host), unescaped path name
> does not work.
> 
> Filenames for DAV repos need to be URI-encoded before being
> passed to the library.  Since this bug did not affect file://
> and svn:// repos, the git-svn test library needed to be expanded
> to include support for starting Apache with mod_dav_svn enabled.
> 
> This new test is not enabled by default, but can be enabled by
> setting SVN_HTTPD_PORT to any available TCP/IP port on
> 127.0.0.1.
> 
> Additionally, for running this test, the following variables
> (with defaults shown) can be changed for the suitable system.
> The default values are set for Debian systems:
> 
>   SVN_HTTPD_MODULE_PATH=/usr/lib/apache2/modules
>   SVN_HTTPD_PATH=/usr/sbin/apache2
> 
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
> 
>  Rogan: the patch should help, a single space anywhere in the
>  path causes SVN to screw up the file names.  Of course I'm at a
>  loss as to why only DAV repositories need it and why the SVN
>  libraries don't abstract that away from me.
> 
Hi Eric,

Unfortunately, I cannot test this patch, as I have since worked around the problem, and it has not reappeared.

If it does, I'll be sure to test and let you know. Unless this patch makes it into the version of git I am using, of course!

Rogan
Previous: Eric Wong
Message 10 of 10 in “git-svn and renames”
  1. Rogan DawesJul 10, 2007
  2. David KastrupJul 10, 2007
  3. Rogan DawesJul 10, 2007
  4. Florian WeimerJul 10, 2007
  5. Rogan DawesJul 10, 2007
  6. Eric WongJul 11, 2007
  7. Eric WongJul 12, 2007
  8. Rogan DawesJul 12, 2007
  9. git-svn: fix commiting renames over DAV with funky file namesEric Wong, Jul 16, 2007
  10. Rogan DawesJul 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.