git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Make fetch-pack a builtin with an internal API

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Jul 9, 2007, 18:04 UTC
Message-ID
<469278B3.40905@lsrfire.ath.cx>
In-Reply-To
<Pine.LNX.4.64.0707090142130.6977@iabervon.org>
Daniel Barkalow schrieb:
Show 9 quoted lines
> On Sun, 8 Jul 2007, Junio C Hamano wrote:
> 
>> Are _identifiers with leading underscore Kosher thing to do, I
>> wonder...  We do have ones with trailing ones (mostly qsort
>> functions) and I think they are done that way for the sake of
>> standards conformance.
> 
> I'm not sure; I inherited that bit of code from Julian. Do we have a 
> standard idiom for a function that sets a bunch of static variables?
You could put all flags and settings into a struct fetch_pack_args.

You could then go one step further by exporting the struct definition and letting the internal interface take a pointer to such a struct, thereby getting rid of static variables and their setup routine.

René
Previous: Daniel BarkalowNext: Daniel Barkalow
Message 4 of 10 in “Make fetch-pack a builtin with an internal API”
  1. Make fetch-pack a builtin with an internal APIDaniel Barkalow, Jul 9, 2007
  2. Junio C HamanoJul 9, 2007
  3. Daniel BarkalowJul 9, 2007
  4. René ScharfeJul 9, 2007
  5. Daniel BarkalowJul 9, 2007
  6. Theodore TsoJul 9, 2007
  7. Andy ParkinsJul 9, 2007
  8. Theodore TsoJul 9, 2007
  9. Florian WeimerJul 9, 2007
  10. Andy ParkinsJul 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.