Re: [RFC PATCH 2/2] Teach git-blame --gui how to start git-gui blame

From: Johannes Sixt <j.sixt@eudaptics.com>
Date: Jun 22, 2007, 08:02 UTC
Message-ID: <467B8232.B6BFDE4A@eudaptics.com>
In-Reply-To: <7vps3oa7kf.fsf@assigned-by-dhcp.pobox.com>

Junio C Hamano wrote:

Show 21 quoted lines

> 
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > Junio C Hamano <gitster@pobox.com> wrote:
> >> This is only minor nuisance, but can we do something about this?
> >>
> >>  $ git gui --version
> >>  Application initialization failed: no display name and no $DISPLAY environment variable
> >>
> >> I know it is from wish, not you, so I wouldn't insist, though.
> >
> > Actually that should be fixable.
> >
> > Should be as simple as using a Bourne shell script up front to
> > check for "z$1" = zversion || "z$1" = z--version, and if so dump
> > back the version, otherwise exec wish.  This is actually quite easy
> > and won't change things for existing users.  I'll put a patch into
> > maint tonight for it.
> 
> If this makes life any harder to people on Windows, especially
> minGW, I would suggest against it.

The MinGW port's exec wrapper looks at the shbang line and runs the shell. Hence, invocation as

  git gui --version

will work even from CMD.EXE. But

  git-gui --version

will only work from MSYS's rxvt.

-- Hannes