Re: [PATCH] Let git-svnimport clean up SVK commit messages.

From: Sam Vilain <sam@vilain.net>
Date: Jun 21, 2007, 06:01 UTC
Message-ID: <467A141D.1050502@vilain.net>
In-Reply-To: <1182392095394-git-send-email-dmo@roaringpenguin.com>

Dave O'Neill wrote:

Show 5 quoted lines

> SVK likes to begin all commit messages with a line of the format:
>    r12345@hostname: user | YYYY-MM-DD HH:MM:SS -ZZZZ
> which makes the import desperately ugly in git.  This adds a -k option to move
> this extra SVK commit line to the end of the commit message, rather than
> keeping it at the beginning.

This is a good idea, of course if somebody didn't specify the magic -I switch to their 'svk sm' incantation then there will be multiple changes listed in a single revision

some examples

http://dev.catalystframework.org/svnweb/Catalyst/revision/?rev=6477 svn log -r 7190:7190 http://svn.pugscode.org/pugs

There was also a pretty nasty bug in SVK which pushed huge commitlogs with no changes

see for example

http://utsl.gen.nz/gitweb/?p=pugs;a=commit;h=817b73f (or: svn log -r 14734:14734 http://svn.pugscode.org/pugs svn diff -r 14733:14734 http://svn.pugscode.org/pugs )

That occurred often enough that it might even be worth detecting and dealing with specially. ie, if multiple SVK changesets are seen in a commit with no changes, mark it as likely bogus.

Yeah, I'm not sure what to say about all this other than "lolsvn".

Sam.