Re: git-p4 fails when cloning a p4 depo.
- From
Han-Wen Nienhuys <hanwen@xs4all.nl>
- Date
- Jun 12, 2007, 01:08 UTC
- Message-ID
- <466DF1FB.6010001@xs4all.nl>
- In-Reply-To
- <200706090038.33799.simon@lst.de>
Simon Hausmann escreveu:
Show 14 quoted lines
> On Friday 08 June 2007 20:13:55 Benjamin Sergeant wrote: >> A perforce command with all the files in the repo is generated to get >> all the file content. >> Here is a patch to break it into multiple successive perforce command >> who uses 4K of parameter max, and collect the output for later. >> >> It works, but not for big depos, because the whole perforce depo >> content is stored in memory in P4Sync.run(), and it looks like mine is >> bigger than 2 Gigs, so I had to kill the process. > > I'd be generally fine with splitting up the "p4 print ..." calls into chunks > but you have a good point with the memory usage. The old approach of calling > print per file did not have any of those limitations. Han-Wen, what do you > think? How much of a performance improvement is the batched print?
One unscientific measurement (getting 1 file vs. 30 files) indicates that this is about 5x times faster.
-- Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen