Re: [PATCH 4/4] Don't link with libsocket in MINGW port

From: Johannes Sixt <j.sixt@eudaptics.com>
Date: May 30, 2007, 12:01 UTC
Message-ID: <465D6796.27B65043@eudaptics.com>
In-Reply-To: <1180492848275-git-send-email-pclouds@gmail.com>

"Nguyá»n ThÃ¡i Ngá»c Duy" wrote:

Show 9 quoted lines

> 
> From: Nguyá»n ThÃ¡i Ngá»c Duy <pclouds@gmail.com>
> 
> There is a check in configure.ac to determine if libc has function
> socket(). It is used to link with libsocket on SunOS.
> 
> On Windows, libc does not have socket() as well but it is provided
> by winsock, not libsocket. So don't link with libsocket if you are
> on Windows.

Show 5 quoted lines

>  ifdef NEEDS_SOCKET
> +ifndef MINGW
>         EXTLIBS += -lsocket
>  endif
> +endif

This looks wrong. NEEDS_SOCKET is set in the architecture sections of Makefile where necessary, but the MinGW section doesn't want it and doesn't set it. If ./configure sets it, then you should fix configure.ac, not work around in Makefile.

-- Hannes

PS: Appologies for the mangled name - this MUA is from the stone age.