git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-archive: recursive prefix directory creation

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 20, 2007, 10:51 UTC
Message-ID
<4650281F.2030301@lsrfire.ath.cx>
In-Reply-To
<7vtzu8va12.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano schrieb:
Show 19 quoted lines
> René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> 
>> Junio C Hamano schrieb:
>>> René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
>>> 
>>>> Currently git-archive only adds a single directory entry for
>>>> prefixes, e.g. for --prefix=a/b/c/ only the directory a/b/c/
>>>> would be added to the archive, not a/ nor a/b/.  While tar and
>>>> unzip don't seem to have a problem handling these missing
>>>> entries, their omission was not intended.
>>> Until we start tracking directories (we briefly discussed, and I 
>>> think I agree with Linus that it should not be too painful), I'd 
>>> rather keep the current behaviour which I feel is more consistent
>>> with what we really are doing.
>> Hmm, fair enough.  I started out with a simple cleanup and then I
>> guess went a bit overboard with that overblown path walker. :-]
> 
> Well, I take that back -- I did not realize you were primarily 
> talking about the LEADING part of the path.

In any case, please don't apply this patch. I checked again, and it turns out both tar and zip don't always add leading directories to archives. So my "cleanup" only adds bloat. I'll try to find another way to beautify the code.

René
Previous: Junio C Hamano
Message 5 of 5 in “git-archive: recursive prefix directory creation”
  1. git-archive: recursive prefix directory creationRené Scharfe, May 19, 2007
  2. Junio C HamanoMay 19, 2007
  3. René ScharfeMay 19, 2007
  4. Junio C HamanoMay 19, 2007
  5. René ScharfeMay 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.