Re: [PATCH 2/3] dir.c: Omit non-excluded directories with dir->show_ignored

From: Michael Spang <mspang@uwaterloo.ca>
Date: May 6, 2007, 20:18 UTC
Message-ID: <463E382F.8080708@uwaterloo.ca>
In-Reply-To: <alpine.LFD.0.98.0705061239460.25245@woody.linux-foundation.org>

Linus Torvalds wrote:

Show 15 quoted lines

> 
> On Sun, 6 May 2007, Michael Spang wrote:
>> @@ -461,7 +462,7 @@ static int read_directory_recursive(struct dir_struct *dir, const char *path, co
>>  			memcpy(fullname + baselen, de->d_name, len+1);
>>  			if (simplify_away(fullname, baselen + len, simplify))
>>  				continue;
>> -			if (excluded(dir, fullname) != dir->show_ignored) {
>> +			if ((exclude = excluded(dir, fullname)) != dir->show_ignored) {
> 
> Style issue: please write this as
> 
> 			exclude = excluded(dir, fullname);
> 			if (exclude != dir->show_ignored) {
> 
> instead.

Okay. Will fixup after waiting a bit for more comments.

Thanks, Michael Spang