Re: [PATCH 5/6] Fix some "comparison is always true/false" warnings.

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Mar 7, 2007, 19:05 UTC
Message-ID: <45EF0D0D.4060904@ramsay1.demon.co.uk>
In-Reply-To: <20070305074502.GA31507@diana.vm.bytemark.co.uk>

Karl Hasselström wrote:

Show 6 quoted lines

> On 2007-03-03 18:28:57 +0000, Ramsay Jones wrote:
> 
>> +typedef unsigned int ucs_char_t;  /* assuming 32bit int */
> 
> Umm ... wouldn't an uint32_t be a better fit here?
>

Yes, but I did not want to add a dependency on a C99 header (i.e. <stdint.h>). I had a vague recollection that Linus had stated that git was probably broken if int wasn't 32 bits, so ...

This was before I realized that a recent change to git meant that git was already including C99 headers <inttypes.h> and, therefore indirectly, <stdint.h>.

So, if it is OK to depend on those headers, then an uin32_t may indeed be a better fit.

All the best,

Ramsay Jones