Re: [PATCH 6/6] Fix a "pointer type missmatch" warning.

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Mar 4, 2007, 16:30 UTC
Message-ID: <45EAF423.8060609@ramsay1.demon.co.uk>
In-Reply-To: <Pine.LNX.4.63.0703031941240.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Hi Johannes,

Johannes Schindelin wrote:

Show 6 quoted lines

> On Sat, 3 Mar 2007, Ramsay Jones wrote:
> 
>> Note: set OLD_ICONV in your config.mak file on Cygwin.
> 
> Shouldn't you set it in Makefile instead?
>

Yes, well the first version of that patch did exactly that! (which caused me to use "git commit --amend" for the first time.)

However, I changed my mind, in order to be consistent with the NO_C99_FORMAT patch (2/6); I am assuming that at some point newlib will update iconv() to the new prototype, and I would have to remove OLD_ICONV from the Makefile again.

To be clear, the setting of both NO_C99_FORMAT and OLD_ICONV in the config.mak file is determined by the capabilities (version) of your compiler/library. (And is not just a Cygwin issue)

Having said that, I don't really mind if it is added to the Makefile.

All the best,

Ramsay Jones