git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Use fixed-size integers for .idx file I/O

From
Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Date
Jan 18, 2007, 14:56 UTC
Message-ID
<45AF8A86.7070101@fs.ei.tum.de>
In-Reply-To
<118833cc0701180651w3b5ac164m4e396399f1d58cb7@mail.gmail.com>
Morten Welinder wrote:
Show 7 quoted lines
>> -                       return ntohl(*((unsigned int *) ((char *) 
>> index + (24 * mi))));
>> +                       return ntohl(*((uint32_t *)((char *)index + 
>> (24 * mi))));
> 
> Is that pointer gymnastics guaranteed to work?  I.e., how do we know
> that we can access an uint32_t (or unsigned) at such an address?
if index is always aligned to a 4-byte boundary, this is safe.  apart from that, the problem already existed.
cheers
  simon
-- 
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \
Previous: Morten WelinderNext: Johannes Schindelin
Message 3 of 6 in “Use fixed-size integers for .idx file I/O”
  1. 2/2 Use fixed-size integers for .idx file I/OJunio C Hamano, Jan 18, 2007
  2. Morten WelinderJan 18, 2007
  3. Simon 'corecode' SchubertJan 18, 2007
  4. Johannes SchindelinJan 18, 2007
  5. Shawn O. PearceJan 18, 2007
  6. Johannes SchindelinJan 18, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.