Re: [PATCH] --utf8 is now default for 'git-am'

From: Johannes Sixt <j.sixt@eudaptics.com>
Date: Jan 9, 2007, 08:28 UTC
Message-ID: <45A35243.FB9FB121@eudaptics.com>
In-Reply-To: <7vlkkduqm6.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 11 quoted lines

> @@ -128,7 +128,9 @@ do
>         -s|--s|--si|--sig|--sign|--signo|--signof|--signoff)
>         sign=t; shift ;;
>         -u|--u|--ut|--utf|--utf8)
> -       utf8=t; shift ;;
> +       shift ;; # this is now default
> +       --no-u|--no-ut|--no-utf|--no-utf8)
> +       utf8=; shift ;;
>         -k|--k|--ke|--kee|--keep)
>         keep=t; shift ;;
>

How is

  git-am --no-utf8 --utf8 mbox

to be interpreted? I'd expect that the last option on the command line has precedence, for example, if git-am is used in a script like this:

  git-am --no-utf8 $userpreferences $mbox

With you patch --no-utf8 always overrides any --utf8 that is specified.

-- Hannes