Re: [PATCH v2 0/3] userdiff: Java updates

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 5, 2023, 10:09 UTC
Message-ID: <45830cf4-41c1-0bc1-3e4e-26b9f713f452@kdbg.org>
In-Reply-To: <20230204134329.251451-1-rybak.a.v@gmail.com>

Am 04.02.23 um 14:43 schrieb Andrei Rybak:

Show 12 quoted lines

> On 04/02/2023 10:22, Tassilo Horn wrote:
>> Thanks for including me being the last contributor to java userdiff.
>> The patches look good from my POV and are safe-guarded with tests, so
>> I'm all for it.
> 
> Thank you for review!
> 
> I've realized that I've been writing modifiers "abstract" and "sealed" in a
> technically correct, but not the conventional order.  Here's a reroll with the
> order of modifiers following the style of original authors of
> https://openjdk.org/jeps/409.  It doesn't matter for the purposes of the test,
> but it will be less annoying to any future readers :-)

I've looked through the patches and run the tests, and they all make sense to me. By just looking at the patch text I noted that no whitespace between the identifier and the opening angle bracket is permitted and whether it should be allowed, but the commit messages make quite clear that whitespace is not allowed in this position. Hence:

Reviewed-by: Johannes Sixt <j6t@kdbg.org>

Thanks, -- Hannes