hooks--pre-commit: chomp() in cygwin perl does not strip "\r"
- From
- Liu Yubao <yubao.liu@gmail.com>
- Date
- Oct 20, 2006, 06:14 UTC
- Message-ID
- <4538692E.6030404@gmail.com>
perl v5.8.7 built for cygwin-thread-multi-64int, its chomp() doesn't strip trailing "\r" so that pre-commit reports "trailing whitespace" for every line. ActiveState Perl v5.8.8 can strip "\r" and "\n" properly.
Changing
if (/\s$/) {
to
if (/[:blank:]$/) {
is also ok.diff --git a/templates/hooks--pre-commit b/templates/hooks--pre-commit index 723a9ef..6a55612 --- a/templates/hooks--pre-commit +++ b/templates/hooks--pre-commit @@ -54,7 +54,7 @@ perl -e ' } if (s/^\+//) { $lineno++; - chomp; + s/[\r\n]+$//; if (/\s$/) { bad_line("trailing whitespace", $_); }