Re: [PATCH] git-sh-setup: Fail if the git directory was not found.
- From
- Robert Shearman <rob@codeweavers.com>
- Date
- Aug 13, 2006, 11:52 UTC
- Message-ID
- <44DF1284.5080406@codeweavers.com>
- In-Reply-To
- <7vlkpuragp.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 10 quoted lines
>Junio C Hamano <junkio@cox.net> writes: > > > >>Moving the assignment of GIT_OBJECT_DIRECTORY is fine, but >>changing it to an unconditional assignment is wrong. The user >>can have a GIT_OBJECT_DIRECTORY set independently from GIT_DIR >>(or ../some/where/.git that is detected). >> >>
I'm not an expert in shell scripting so I didn't notice that it was a conditional assignment.
>How about this as a replacement? > >
Looks good.
Thanks,
-- Rob Shearman