git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/9] Add has_extension()

From
Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Aug 10, 2006, 17:48 UTC
Message-ID
<44DB7178.4090706@lsrfire.ath.cx>
In-Reply-To
<Pine.LNX.4.63.0608101825000.10541@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin schrieb:
Show 6 quoted lines
> On Thu, 10 Aug 2006, Rene Scharfe wrote:
> 
>> The little helper has_extension() documents through its name what we are
>> trying to do and makes sure we don't forget the underrun check.
> 
> While I think it is a good change, it is independent of verify-pack, no?

I could have limited has_extension() to verify-pack.c initially and then sent a conversion for the other files after this series had been accepted, yes. It's one of the main cleanups for verify_one_pack(), though, because it allowed me to drop some comments -- without losing readability (IMHO).

I could have documented it broader scope better in the commit message. :-/

Thanks, René

Previous: Johannes SchindelinNext: Fredrik Kuivinen
Message 4 of 18 in “git-verify-pack: clean up and make builtin”
  1. 0/9 git-verify-pack: clean up and make builtinRene Scharfe, Aug 10, 2006
  2. 1/9 Add has_extension()Rene Scharfe, Aug 10, 2006
  3. Johannes SchindelinAug 10, 2006
  4. Rene ScharfeAug 10, 2006
  5. Fredrik KuivinenAug 10, 2006
  6. Rene ScharfeAug 10, 2006
  7. Fredrik KuivinenAug 10, 2006
  8. 2/9 git-verify-pack: show usage when no pack was specifiedRene Scharfe, Aug 10, 2006
  9. 3/9 git-verify-pack: more careful path handlingRene Scharfe, Aug 10, 2006
  10. 4/9 git-verify-pack: insist on .idx extensionRene Scharfe, Aug 10, 2006
  11. 5/9 git-verify-pack: get rid of while loopRene Scharfe, Aug 10, 2006
  12. 6/9 git-verify-pack: free pack after use and a cleanupRene Scharfe, Aug 10, 2006
  13. 7/9 git-verify-pack: buffer overrun paranoiaRene Scharfe, Aug 10, 2006
  14. 8/9 git-verify-pack: no need to count errorsRene Scharfe, Aug 10, 2006
  15. Johannes SchindelinAug 10, 2006
  16. Rene ScharfeAug 10, 2006
  17. 9/9 git-verify-pack: make builtinRene Scharfe, Aug 10, 2006
  18. Johannes SchindelinAug 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.